Merged
Conversation
Member
|
Code looks good 👍 Can you check what the compile times before/ after are for a large-ish set of files (maybe try 10–20)? I want to make sure we don't regress too much on that measure. |
Member
|
🎩 went well, code's good. 🚢 assuming there isn't a significant perf regression. |
Contributor
Author
|
I ran it on all coffeescript files in
|
Member
|
So, like, ~125ms/file? For the use case of many people updating one file at a time, looks worth it to me. |
Member
|
🐑 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to load local eslint and process with --fix.
Fixes #185
@lemonmade @GoodForOneFare